Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LocalNet] Add gas fees #940

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[LocalNet] Add gas fees #940

wants to merge 8 commits into from

Conversation

okdas
Copy link
Member

@okdas okdas commented Nov 21, 2024

Summary

Adds a requirement for all transactions to be supplied with gas on LocalNet.

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas self-assigned this Nov 21, 2024
@okdas okdas added the infra Infra or tooling related improvements, additions or fixes label Nov 21, 2024
@okdas okdas mentioned this pull request Dec 2, 2024
Open
6 tasks
@okdas
Copy link
Member Author

okdas commented Dec 9, 2024 •
edited
Loading

  1. It doesn't appear we have a good way to change the default flag values (such as --gas=) on a current version of cosmos-sdk. The new cosmos-sdk code (in their main branch) has support for better handling of client.toml file, which does allow changing such flags. I was sure this is doable now, but I couldn't find the place to change the values so ALL poktrolld tx sub-commands would comply. So, instead, I started adding these flags to the command line commands we use (such as makefile targets).
  2. While some changes to e2e tests were expected, I did not expect so many weird side-effects I couldn't easily explain. Such as params were changing in unpredictable ways, some places in e2e tests now required a upokt denomination instead of just pokt.

I'm sure all of this is fixable, but there are more important issues to tackle right and this feels like a time sink now so I'm going to postpone working on that PR.

@Olshansk
Copy link
Member

Olshansk commented Dec 9, 2024

@okdas Should we:

  1. Close this PR
  2. Move [Foundation] Add gas fees #794 to a future iteration
  3. Ask the cosmos SDK team when the main branch will be cut to a new release
  4. Do this only after (3) is complete?

@okdas okdas mentioned this pull request Dec 17, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okdas okdas

Labels
infra Infra or tooling related improvements, additions or fixes
Projects
Shannon
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@okdas @Olshansk